![]() So actually your change seems to break this, or at least your change now causes behavior that breaks my expectations as a user. touch /var/log/cron touch /var/log/boot.log mkdir -p /var/cache/yum /usr/sbin/fixfiles -R -a. ![]() Looks like _.defaults doesn't override stuff, but _.assign behaves differently. but we dont ship it in cloud dnf -C -y remove firewalld. but that seems completely broken, because now we have no way to override the rsync flags for special cases. Maybe I'm just missing something? I git blamed this line and there is a commit that implies that this is actually what the desired behavior is. sync-type: rsync sync-uri: rsync:///gentoo-portage. I can get a PR with this change if there is consensus that this is indeed a bug. RUN mkdir A Make the working directory A WORKDIR A Make two directories. 'copy' method is deprecated, please use 'copyToRemote', 'copyFromRemote', 'scpCopyToRemote' or 'scpCopyFromRemote'. dependencies, and system settings - and ship it all out as one package. So, it seems like the order here should be swapped so that rsync is copied from nfig first, and options last, which would allow you to actually override the rsync behavior when you want to. As rsync is listed in dependencies I would expected some error, but instead shipit uses tar: when no rsync is installed Copy project to remote servers. So if I understand that correctly, we copy all properties from options, then override rsync and ignores with a value from nfig or (redundantly) options if is undefined. Not only that, but it looks like, according to, _.assign will copy properties from the sources from left to right. Why should we obey nfig over the opts arguments that are passed in? Expected behavior is to be able to override rsync behavior when we need to by using the options argument. Added a mkdir for VARDIR/output if dir does not exist (issue 440). In remoteCopy, will always be used, if it is specified. Clarified rear man page and nf file around BACKUPURLrsync: (issues 930.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |